Add handler factory support #8
Conversation
| use Equip\Queue\Exception\RouterException; | ||
| use Equip\Queue\RouterInterface; | ||
|
|
||
| class Router implements RouterInterface |
There was a problem hiding this comment.
For an example class?
There was a problem hiding this comment.
Ah, didn't notice the path. Feel free to disregard. Though, is this implementation not usable on its own outside of being an example? Are we going to expect that library users will implement their own router classes?
There was a problem hiding this comment.
I didn't plan on providing an implementation, but this one turned out alright. I'll add it.
| use Equip\Queue\Exception\HandlerException; | ||
| use Equip\Queue\Exception\RouterException; | ||
|
|
||
| class SimpleRouter implements RouterInterface |
There was a problem hiding this comment.
Why is this called a router and not factory?
| use Equip\Queue\Exception\HandlerException; | ||
| use Equip\Queue\Exception\RouterException; | ||
|
|
||
| class SimpleRouteFactory implements RouteFactoryInterface |
There was a problem hiding this comment.
But why is it called "Route" at all?
| interface RouteFactoryInterface | ||
| { | ||
| /** | ||
| * Retrieve callable for message |
There was a problem hiding this comment.
Based on this comment, it seems like this interface should be named HandlerFactoryInterface?
| */ | ||
| private $handlers; | ||
| private $handler_factory; |
There was a problem hiding this comment.
$handler, $factory, or leave it as it is?
There was a problem hiding this comment.
I think it's okay as is, though if you do rename it, I'd opt for $handlers.
There was a problem hiding this comment.
I like $handlers better, updated.
|
|
||
| /** | ||
| * @param DriverInterface $driver | ||
| * @param Event $event | ||
| * @param LoggerInterface $logger | ||
| * @param MessageSerializerInterface $serializer | ||
| * @param RouteFactoryInterface $router | ||
| * @param HandlerFactoryInterface $handler_factory |
|
👍 |
Adding handler factories ensures a clean slate when executing each job.