Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix span missing bug #2820

Conversation

recallsong
Copy link
Contributor

What type of this PR

/kind bugfix

What this PR does / why we need it:

fix span missing bug

Specified Reviewers:

/assign @liuhaoyang

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #2820 (1ee6c51) into release/1.3 (737d55d) will increase coverage by 0.00%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.3    #2820   +/-   ##
============================================
  Coverage        16.15%   16.15%           
============================================
  Files             1212     1212           
  Lines           122150   122167   +17     
============================================
+ Hits             19730    19739    +9     
+ Misses          100404   100374   -30     
- Partials          2016     2054   +38     
Impacted Files Coverage Δ
modules/msp/apm/trace/storage/consumer.go 37.58% <78.57%> (+4.73%) ⬆️
modules/msp/apm/trace/trace.service.go 30.04% <87.50%> (-1.32%) ⬇️
pkg/parser/pipelineyml/visitor_ref_op.go 46.23% <0.00%> (-0.54%) ⬇️
.../pipengine/reconciler/queuemanage/manager/queue.go 15.78% <0.00%> (+2.96%) ⬆️

@liuhaoyang
Copy link
Contributor

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 9, 2021
* fix span missing bug

* imports

* adjust

* use positiveInt64

* imports
liuhaoyang pushed a commit that referenced this pull request Nov 9, 2021
* fix span missing bug

* imports

* adjust

* use positiveInt64

* imports

Co-authored-by: RecallSong <13607438+recallsong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants