-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basemap Service Plugin #86
Conversation
quest_provider_plugins/Basemap.py
Outdated
url = 'http://c.tile.openstreetmap.org/{0}/{1}/{2}.png' | ||
|
||
combined_latitudes_list = [p.lat_1, p.lat_2] | ||
convereted_lat_tile_list = [int(1 / (2 * math.pi) * 2 ** p.zoom_level * (math.pi - math.log(math.tan(math.pi / 4 + math.radians(y) / 2)))) for y in combined_latitudes_list] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (180 > 120 characters)
quest_provider_plugins/Basemap.py
Outdated
combined_longitudes_list = [p.long_1, p.long_2] | ||
convereted_long_tile_list = [int(2 ** (p.zoom_level - 1) * (x / 180 + 1)) for x in combined_longitudes_list] | ||
|
||
first_lat = math.degrees(2 * (math.atan(math.exp(math.pi - (convereted_long_tile_list[0] * 2 * math.pi) / 2 ** p.zoom_level)) - math.pi / 4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (149 > 120 characters)
quest_provider_plugins/Basemap.py
Outdated
convereted_long_tile_list = [int(2 ** (p.zoom_level - 1) * (x / 180 + 1)) for x in combined_longitudes_list] | ||
|
||
first_lat = math.degrees(2 * (math.atan(math.exp(math.pi - (convereted_long_tile_list[0] * 2 * math.pi) / 2 ** p.zoom_level)) - math.pi / 4)) | ||
second_lat = math.degrees(2 * (math.atan(math.exp(math.pi - ((convereted_long_tile_list[-1] + 1) * 2 * math.pi) / 2 ** p.zoom_level)) - math.pi / 4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (157 > 120 characters)
quest_provider_plugins/Basemap.py
Outdated
stitched_image.save(file_path) | ||
src = rasterio.open(file_path, 'r+') | ||
src.crs = rasterio.crs.CRS.from_epsg(3857) | ||
src.transform = rasterio.transform.from_bounds(first_long, second_lat, second_long, first_lat, number_of_y_tiles * 256, number_of_x_tiles * 256) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (152 > 120 characters)
quest_provider_plugins/Basemap.py
Outdated
src.close() | ||
stitched_image.close() | ||
|
||
class BasemapProvider(ProviderBase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1
quest_provider_plugins/Basemap.py
Outdated
organization_name = 'Basemap' | ||
name = 'Basemap' | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W391 blank line at end of file
quest_provider_plugins/Basemap.py
Outdated
long_range = range(convereted_long_tile_list[0], (convereted_long_tile_list[1] + 1)) | ||
|
||
loop_iterator = 0 | ||
stitched_image = Image.new('RGB', (number_of_y_tiles * 256, numbeer_of_x_tiles * 256)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F821 undefined name 'numbeer_of_x_tiles'
quest_provider_plugins/Basemap.py
Outdated
|
||
first_lat = math.degrees(2 * (math.atan(math.exp(math.pi - | ||
(convereted_long_tile_list[0] * 2 * math.pi) | ||
/ 2 ** p.zoom_level)) - math.pi / 4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W503 line break before binary operator
quest_provider_plugins/Basemap.py
Outdated
|
||
second_lat = math.degrees(2 * (math.atan(math.exp(math.pi - | ||
((convereted_long_tile_list[-1] + 1) * 2 * math.pi) | ||
/ 2 ** p.zoom_level)) - math.pi / 4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W503 line break before binary operator
quest_provider_plugins/Basemap.py
Outdated
display_name = 'Basemap Provider' | ||
description = 'Services avaliable through the live Basemap Server.' | ||
organization_name = 'Basemap' | ||
name = 'Basemap' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W292 no newline at end of file
…p plugin, beecause I don't think it was suppose to be there.
quest_provider_plugins/Basemap.py
Outdated
|
||
# Get the basemap tiles for the given coordinates. | ||
converted_lat_tile_list = [int(1 / (2 * math.pi) * 2 ** p.zoom_level * (math.pi - math.log(math.tan(math.pi | ||
/ 4 + math.radians(y) / 2)))) for y in [bbox[3], bbox[1]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
W503 line break before binary operator
quest_provider_plugins/Basemap.py
Outdated
# Why I am doing this is because we have to geo-reference the image and have the exact coordinates of the | ||
# - actual image that we will stitch together from these tiles. | ||
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0]*2*math.pi) | ||
/2**p.zoom_level))-math.pi/4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W503 line break before binary operator
E225 missing whitespace around operator
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0]*2*math.pi) | ||
/2**p.zoom_level))-math.pi/4)) | ||
second_lat = math.degrees(2*(math.atan(math.exp(math.pi-((converted_long_tile_list[-1] + 1)*2*math.pi) | ||
/2**p.zoom_level))-math.pi/4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W503 line break before binary operator
E225 missing whitespace around operator
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
second_long = math.degrees((converted_lat_tile_list[-1] + 1)*2*math.pi/(2**p.zoom_level) - math.pi) | ||
|
||
|
||
# Have to create a range item so that we can do a product on it later in the algorithm. So lets increment, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E303 too many blank lines (2)
quest_provider_plugins/Basemap.py
Outdated
import numpy as np | ||
import requests | ||
import rasterio | ||
import warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'warnings' imported but unused
quest_provider_plugins/Basemap.py
Outdated
# - tile and caculate the coordinates of its top left hand corner. | ||
# Why I am doing this is because we have to geo-reference the image and have the exact coordinates of the | ||
# - actual image that we will stitch together from these tiles. | ||
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0]*2*math.pi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
# - actual image that we will stitch together from these tiles. | ||
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0]*2*math.pi) | ||
/2**p.zoom_level))-math.pi/4)) | ||
second_lat = math.degrees(2*(math.atan(math.exp(math.pi-((converted_long_tile_list[-1] + 1)*2*math.pi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
second_lat = math.degrees(2*(math.atan(math.exp(math.pi-((converted_long_tile_list[-1] + 1)*2*math.pi) | ||
/2**p.zoom_level))-math.pi/4)) | ||
|
||
first_long = math.degrees(converted_lat_tile_list[0]*2*math.pi/(2**p.zoom_level) - math.pi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
/2**p.zoom_level))-math.pi/4)) | ||
|
||
first_long = math.degrees(converted_lat_tile_list[0]*2*math.pi/(2**p.zoom_level) - math.pi) | ||
second_long = math.degrees((converted_lat_tile_list[-1] + 1)*2*math.pi/(2**p.zoom_level) - math.pi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
loop_iterator = 0 | ||
stitched_image = Image.new('RGB', (number_of_x_tiles * 256, number_of_y_tiles * 256)) | ||
for x, y in product(long_range_list, lat_range_list): | ||
key = {"Z": p.zoom_level, "z": p.zoom_level, "X": x, "x": x, "Y": y, "y": y} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F841 local variable 'key' is assigned to but never used
quest_provider_plugins/Basemap.py
Outdated
display_name = 'Basemap Provider' | ||
description = 'Services avaliable through the live Basemap Server.' | ||
organization_name = 'Basemap' | ||
name = 'basemap' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W292 no newline at end of file
@@ -362,7 +362,45 @@ | |||
['NAM NEST over PUERTO RICO (3 km Resolution - Grid 194)', | |||
'NAM NEST over PUERTO RICO (3 km Resolution - Grid 194)']], | |||
'type': 'ObjectSelector'}], | |||
'title': 'NCEP NAM Service Download Options'} | |||
'title': 'NCEP NAM Service Download Options'}, | |||
'svc://basemap:Web Mercator Tile Service': {'properties': [{'default': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E131 continuation line unaligned for hanging indent
'title': 'NCEP NAM Service Download Options'} | ||
'title': 'NCEP NAM Service Download Options'}, | ||
'svc://basemap:Web Mercator Tile Service': {'properties': [{'default': None, | ||
'description': '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
'title': 'NCEP NAM Service Download Options'}, | ||
'svc://basemap:Web Mercator Tile Service': {'properties': [{'default': None, | ||
'description': '', | ||
'name': 'url', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
'svc://basemap:Web Mercator Tile Service': {'properties': [{'default': None, | ||
'description': '', | ||
'name': 'url', | ||
'range': [['http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
test/data.py
Outdated
'description': '', | ||
'name': 'zoom_level', | ||
'type': 'Integer'}, | ||
{'default': '-180, 90, 180, -90', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
test/data.py
Outdated
'name': 'zoom_level', | ||
'type': 'Integer'}, | ||
{'default': '-180, 90, 180, -90', | ||
'description': 'x-min, y-max, x-max, x-min', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
test/data.py
Outdated
'type': 'Integer'}, | ||
{'default': '-180, 90, 180, -90', | ||
'description': 'x-min, y-max, x-max, x-min', | ||
'name': 'bbox', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
test/data.py
Outdated
{'default': '-180, 90, 180, -90', | ||
'description': 'x-min, y-max, x-max, x-min', | ||
'name': 'bbox', | ||
'type': 'String'}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
@@ -362,7 +362,45 @@ | |||
['NAM NEST over PUERTO RICO (3 km Resolution - Grid 194)', | |||
'NAM NEST over PUERTO RICO (3 km Resolution - Grid 194)']], | |||
'type': 'ObjectSelector'}], | |||
'title': 'NCEP NAM Service Download Options'} | |||
'title': 'NCEP NAM Service Download Options'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
quest_provider_plugins/Basemap.py
Outdated
# Why I am doing this is because we have to geo-reference the image and have the exact coordinates of the | ||
# - actual image that we will stitch together from these tiles. | ||
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0] | ||
*2*math.pi)/2**p.zoom_level))-math.pi/4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W503 line break before binary operator
E225 missing whitespace around operator
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
# - tile and caculate the coordinates of its top left hand corner. | ||
# Why I am doing this is because we have to geo-reference the image and have the exact coordinates of the | ||
# - actual image that we will stitch together from these tiles. | ||
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
# - actual image that we will stitch together from these tiles. | ||
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0] | ||
*2*math.pi)/2**p.zoom_level))-math.pi/4)) | ||
second_lat = math.degrees(2*(math.atan(math.exp(math.pi-(( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
first_lat = math.degrees(2*(math.atan(math.exp(math.pi-(converted_long_tile_list[0] | ||
*2*math.pi)/2**p.zoom_level))-math.pi/4)) | ||
second_lat = math.degrees(2*(math.atan(math.exp(math.pi-(( | ||
converted_long_tile_list[-1] + 1)*2*math.pi)/2**p.zoom_level))-math.pi/4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E126 continuation line over-indented for hanging indent
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
second_lat = math.degrees(2*(math.atan(math.exp(math.pi-(( | ||
converted_long_tile_list[-1] + 1)*2*math.pi)/2**p.zoom_level))-math.pi/4)) | ||
|
||
first_long = math.degrees(converted_lat_tile_list[0]*2*math.pi/(2**p.zoom_level) - math.pi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
quest_provider_plugins/Basemap.py
Outdated
converted_long_tile_list[-1] + 1)*2*math.pi)/2**p.zoom_level))-math.pi/4)) | ||
|
||
first_long = math.degrees(converted_lat_tile_list[0]*2*math.pi/(2**p.zoom_level) - math.pi) | ||
second_long = math.degrees((converted_lat_tile_list[-1] + 1)*2*math.pi/(2**p.zoom_level) - math.pi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E226 missing whitespace around arithmetic operator
test/data.py
Outdated
'title': 'NCEP NAM Service Download Options'} | ||
'title': 'NCEP NAM Service Download Options'}, | ||
'svc://basemap:Web Mercator Tile Service': {'properties': [{'default': None, | ||
'description': '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
test/data.py
Outdated
'title': 'NCEP NAM Service Download Options'}, | ||
'svc://basemap:Web Mercator Tile Service': {'properties': [{'default': None, | ||
'description': '', | ||
'name': 'url', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
test/data.py
Outdated
'svc://basemap:Web Mercator Tile Service': {'properties': [{'default': None, | ||
'description': '', | ||
'name': 'url', | ||
'range': [['http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
test/data.py
Outdated
'description': '', | ||
'name': 'url', | ||
'range': [['http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png', | ||
'http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
test/data.py
Outdated
@@ -362,7 +362,45 @@ | |||
['NAM NEST over PUERTO RICO (3 km Resolution - Grid 194)', | |||
'NAM NEST over PUERTO RICO (3 km Resolution - Grid 194)']], | |||
'type': 'ObjectSelector'}], | |||
'title': 'NCEP NAM Service Download Options'} | |||
'title': 'NCEP NAM Service Download Options'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
test/data.py
Outdated
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}']], | ||
'type': 'ObjectSelector'}, | ||
{'bounds': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
test/data.py
Outdated
'description': 'x-min, y-max, x-max, x-min', | ||
'name': 'bbox', | ||
'type': 'String'}], | ||
'title': 'WMTS Download Options'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
quest_provider_plugins/Basemap.py
Outdated
|
||
# Get the basemap tiles for the given coordinates. | ||
converted_lat_tile_list = [int(1 / (2 * math.pi) * 2 ** p.zoom_level * (math.pi - math.log(math.tan(math.pi | ||
/ 4 + math.radians(y) / 2)))) for y in [bbox[3], bbox[1]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
W503 line break before binary operator
test/data.py
Outdated
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}']], | ||
'type': 'ObjectSelector'}, | ||
{'bounds': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
test/data.py
Outdated
'name': 'url', | ||
'range': [['http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.\ | ||
png', | ||
'http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
test/data.py
Outdated
'range': [['http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.\ | ||
png', | ||
'http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png'], | ||
['http://tile.stamen.com/terrain/{Z}/{X}/{Y}.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
test/data.py
Outdated
png', | ||
'http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png'], | ||
['http://tile.stamen.com/terrain/{Z}/{X}/{Y}.png', | ||
'http://tile.stamen.com/terrain/{Z}/{X}/{Y}.png'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
test/data.py
Outdated
'http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png'], | ||
['http://tile.stamen.com/terrain/{Z}/{X}/{Y}.png', | ||
'http://tile.stamen.com/terrain/{Z}/{X}/{Y}.png'], | ||
['https://s.basemaps.cartocdn.com/light_all/{Z}/{X}/{Y}.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
test/data.py
Outdated
['http://tile.stamen.com/terrain/{Z}/{X}/{Y}.png', | ||
'http://tile.stamen.com/terrain/{Z}/{X}/{Y}.png'], | ||
['https://s.basemaps.cartocdn.com/light_all/{Z}/{X}/{Y}.png', | ||
'https://s.basemaps.cartocdn.com/light_all/{Z}/{X}/{Y}.png'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Street_Map/MapServer/tile/{Z}/{Y}/{X}'], | ||
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Terrain_Base/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Terrain_Base/MapServer/tile/{Z}/{Y}/{X}'], | ||
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Terrain_Base/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Terrain_Base/MapServer/tile/{Z}/{Y}/{X}'], | ||
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}']], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E122 continuation line missing indentation or outdented
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Terrain_Base/MapServer/tile/{Z}/{Y}/{X}'], | ||
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}']], | ||
'type': 'ObjectSelector'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
test/data.py
Outdated
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}']], | ||
'type': 'ObjectSelector'}, | ||
{'bounds': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
test/data.py
Outdated
'description': 'x-min, y-max, x-max, y-min', | ||
'name': 'bbox', | ||
'type': 'String'}], | ||
'title': 'WMTS Download Options'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
…were before trying to correct the ci changes.
test/data.py
Outdated
['https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}', | ||
'https://server.arcgisonline.com/ArcGIS/rest/services/World_Topo_Map/MapServer/tile/{Z}/{Y}/{X}']], | ||
'type': 'ObjectSelector'}, | ||
{'bounds': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E121 continuation line under-indented for hanging indent
- param | ||
- psutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to leave this dependance in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm I'm not entirely sure, I've never really messed with this dependency before. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just alphabetized the list of dependencies and psutil was just moved. Thanks
conda_environment.yml
Outdated
- param | ||
- psutil | ||
- pillow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this down into the plugin dependencies section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Thanks
Here is a rough version of the Basemap plugin that lacks ESRI capability. The next couple steps are to add the ESRI functionality, and updating how we convert a PIL image to rasterio image. There is still uncertainty that the image is actually a geotiff image. @dharhas can you see if this will fit into your workflow? Thanks.