`update-pool` command failed on loading oracle_config_updated.yaml with UnknownRefreshNftId error

[greenhat]

Discovered in #118

❯ cargo build && ./target/debug/oracle-core update-pool
    Finished dev [unoptimized + debuginfo] target(s) in 0.11s
2022-11-15T17:52:44.540492804+02:00 INFO oracle_core - v2.0.0-alpha1+6677721 Mon Nov 14 18:31:36 2022 +0200
2022-11-15T17:52:44.540538774+02:00 INFO oracle_core - Token ids: TokenIds { pool_nft_token_id: TokenId("bf1c100d3fa68b9eb486d6032d4b2e3d6abe3952faeb8a999877e6cf517b337e"), refresh_nft_token_id: TokenId("4774b39aaf9bd8e62751e6d789e856bc26d6d33b8a72379dcb735c0ac2158465"), update_nft_token_id: TokenId("729447a36d774520cdda2dd6730e0ba3f7ce2161e253fa85c50ab1547e7b909c"), oracle_token_id: TokenId("c7e3691bce1ca08125c9ecb0960d4d71c8efd4db876910620864db701d8cc99c"), reward_token_id: TokenId("1869456994a17dc0d8a67888c278f139299320ca773f9c728d93c3a0b2efe4fb"), ballot_token_id: TokenId("c3e6a531170c90c0e10701dbd676c7e4724e352a7449fcf37243ed0b64a0773c") }
2022-11-15T17:52:44.540705175+02:00 INFO oracle_core - Oracle address: 3Wy3BaCjGDWE3bjjZkNo3aWaMz3cYrePMFhchcKovY9uG9vhpAuW
2022-11-15T17:52:44.582439246+02:00 INFO oracle_core::cli_commands::update_pool - Opening oracle_config_updated.yaml
2022-11-15T17:52:44.586691022+02:00 ERROR oracle_core - Fatal update-pool error: Update pool: yaml error Oracle config error: Pool contract error: contract error: UnknownRefreshNftId, expected P2S: 1004040204000e207c828a35b6ee5e4f92d50a9f74fad66d3ce1822db62f655335c4e3d567a7837e0e20729447a36d774520cdda2dd6730e0ba3f7ce2161e253fa85c50ab1547e7b909cd801d6018cb2db6308b2a473000073010001d1ec93720173029372017303

[greenhat]

The reason is that on prepare-update command, pool contract parameters were omitted:

---
refresh_contract_parameters:
  ergo_tree_bytes: 1016043c040004000e20c7e3691bce1ca08125c9ecb0960d4d71c8efd4db876910620864db701d8cc99c01000502010105000400040004020402040204040400040a05c8010e20bf1c100d3fa68b9eb486d6032d4b2e3d6abe3952faeb8a999877e6cf517b337e0400040404020408d80ed60199a37300d602b2a4730100d603b5a4d901036395e6c672030605eded928cc77203017201938cb2db6308720373020001730393e4c672030504e4c6720205047304d604b17203d605b0720386027305860273067307d901053c413d0563d803d607e4c68c7205020605d6088c720501d6098c720802860272078602ed8c720901908c72080172079a8c7209027207d6068c720502d6078c720501d608db63087202d609b27208730800d60ab2a5730900d60bdb6308720ad60cb2720b730a00d60db27208730b00d60eb2a5730c00ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02ea02cde4c6b27203e4e30004000407d18f8cc77202017201d1927204730dd18c720601d190997207e4c6b27203730e0006059d9c72077e730f057310d1938c7209017311d193b2720b7312007209d1938c720c018c720d01d1928c720c02998c720d027e9c7204731305d193b1720bb17208d193e4c6720a04059d8c7206027e720405d193e4c6720a05049ae4c6720205047314d193c2720ac27202d192c1720ac17202d1928cc7720a0199a37315d193db6308720edb6308a7d193c2720ec2a7d192c1720ec1a7
  pool_nft_index: 17
  oracle_token_id_index: 3
  min_data_points_index: 13
  min_data_points: 2
  buffer_length_index: 21
  buffer_length: 4
  max_deviation_percent_index: 15
  max_deviation_percent: 5
  epoch_length_index: 0
  epoch_length: 20
tokens_to_mint:
  pool_nft: ~
  refresh_nft:
    name: refresh NFT
    description: refresh NFT
  update_nft: ~
  oracle_tokens: ~
  ballot_tokens: ~
  reward_tokens: ~

because only epoch_length was changed. However, due to new refresh token was minted it should've been updated in the pool contract as weell. But since it was omitted in the yaml file the it was skipped in the following code:

oracle-core/core/src/cli_commands/prepare_update.rs

Lines 392 to 401 in 5ca9e54

	if let Some(new_pool_contract_parameters) = config.pool_contract_parameters {
	let new_pool_box_wrapper_inputs = PoolBoxWrapperInputs::build_with(
	new_pool_contract_parameters,
	new_oracle_config.token_ids.refresh_nft_token_id.clone(),
	new_oracle_config.token_ids.update_nft_token_id.clone(),
	new_oracle_config.token_ids.pool_nft_token_id.clone(),
	new_oracle_config.token_ids.reward_token_id.clone(),
	)?;
	new_oracle_config.pool_box_wrapper_inputs = new_pool_box_wrapper_inputs;
	}