Skip to content

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Sep 14, 2022

@coveralls
Copy link

coveralls commented Sep 14, 2022

Pull Request Test Coverage Report for Build 3095704962

  • 44 of 162 (27.16%) changed or added relevant lines in 19 files are covered.
  • 16 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.3%) to 69.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/cli_commands/print_reward_tokens.rs 0 1 0.0%
core/src/cli_commands/vote_update_pool.rs 8 10 80.0%
core/src/pool_commands/test_utils.rs 8 10 80.0%
core/src/main.rs 0 4 0.0%
core/src/scans.rs 0 4 0.0%
core/src/state.rs 0 4 0.0%
core/src/actions.rs 0 6 0.0%
core/src/api.rs 0 7 0.0%
core/src/node_interface.rs 0 7 0.0%
core/src/pool_commands.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/cli_commands/extract_reward_tokens.rs 1 75.86%
core/src/cli_commands/transfer_oracle_token.rs 1 71.79%
core/src/main.rs 1 0%
core/src/node_interface.rs 1 0%
core/src/pool_commands.rs 1 0%
core/src/state.rs 1 0%
core/src/box_kind/ballot_box.rs 2 88.04%
core/src/api.rs 3 0%
core/src/oracle_state.rs 5 0%
Totals Coverage Status
Change from base Build 3088268486: 0.3%
Covered Lines: 2380
Relevant Lines: 3402

💛 - Coveralls

@greenhat greenhat changed the title Handle no oracle box present on oracle joining/starting a pool Handle no oracle box present on oracle joining/starting a pool + other discovered bugs Sep 20, 2022
@greenhat greenhat force-pushed the after-bootstrap-fixes branch from dcb0f67 to 9b14319 Compare September 21, 2022 06:35
@greenhat greenhat marked this pull request as ready for review September 21, 2022 06:43
@greenhat greenhat requested a review from kettlebell September 21, 2022 06:57
Copy link
Collaborator

@kettlebell kettlebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I could not find a fault! I liked how you used commits to link to particular issues. A neat trick that I'll look to use in the future.

@kettlebell kettlebell merged commit 12c065a into develop Sep 22, 2022
@kettlebell kettlebell deleted the after-bootstrap-fixes branch September 22, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants