Skip to content

Re-register UTXO-set-scans after UpdatePool command #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2022
Merged

Re-register UTXO-set-scans after UpdatePool command #113

merged 5 commits into from
Sep 20, 2022

Conversation

kettlebell
Copy link
Collaborator

Close #110

@coveralls
Copy link

coveralls commented Sep 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3088023562

  • 0 of 46 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 69.697%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/oracle_state.rs 0 46 0.0%
Totals Coverage Status
Change from base Build 3087867573: -0.3%
Covered Lines: 2392
Relevant Lines: 3432
💛 - Coveralls

@kettlebell kettlebell marked this pull request as ready for review September 19, 2022 04:31
@kettlebell kettlebell requested a review from greenhat September 19, 2022 04:32
greenhat
greenhat requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a minor note.

@kettlebell kettlebell requested a review from greenhat September 20, 2022 03:47
greenhat
greenhat requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just one tiny comment. :)

@kettlebell kettlebell requested a review from greenhat September 20, 2022 07:02
greenhat
greenhat approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@greenhat greenhat merged commit 857114c into develop Sep 20, 2022
@greenhat greenhat deleted the i110_update_scans branch September 20, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenhat greenhat greenhat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[200 SigmaUSD] Update registered scans and re-scan the wallet after UpdatePool command
3 participants
@kettlebell @coveralls @greenhat