Skip to content

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Sep 29, 2022

@coveralls
Copy link

coveralls commented Sep 29, 2022

Pull Request Test Coverage Report for Build 3180054659

  • 21 of 78 (26.92%) changed or added relevant lines in 8 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 70.911%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/pool_commands/refresh.rs 0 5 0.0%
core/src/state.rs 0 6 0.0%
core/src/actions.rs 0 11 0.0%
core/src/oracle_state.rs 0 13 0.0%
core/src/main.rs 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/api.rs 1 0%
core/src/main.rs 1 0%
core/src/actions.rs 2 0%
core/src/oracle_state.rs 5 0%
Totals Coverage Status
Change from base Build 3149575678: -0.2%
Covered Lines: 2445
Relevant Lines: 3448

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review September 30, 2022 12:25
c.token_ids.oracle_token_id.clone(),
c.token_ids.reward_token_id.clone(),
c.token_ids.pool_nft_token_id.clone(),
c.token_ids.refresh_nft_token_id.clone(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the kind of error I wanted to eliminate when I made #47

@greenhat greenhat requested a review from kettlebell September 30, 2022 12:41
Copy link
Collaborator

@kettlebell kettlebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small typo to fix.

@greenhat greenhat requested a review from kettlebell October 4, 2022 07:01
Copy link
Collaborator

@kettlebell kettlebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@kettlebell kettlebell merged commit 11bbcf6 into develop Oct 4, 2022
@kettlebell kettlebell deleted the i121-datapoint-doublespending branch October 4, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants