-
Notifications
You must be signed in to change notification settings - Fork 38
Fixes for issues discovered while running one oracle #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
handle error on scan registration and remove redundant scan registration check;
Pull Request Test Coverage Report for Build 3180054659
💛 - Coveralls |
add more details to logging;
c.token_ids.oracle_token_id.clone(), | ||
c.token_ids.reward_token_id.clone(), | ||
c.token_ids.pool_nft_token_id.clone(), | ||
c.token_ids.refresh_nft_token_id.clone(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the kind of error I wanted to eliminate when I made #47
collected on refresh action;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a small typo to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
Uh oh!
There was an error while loading. Please reload this page.