More conventional dotfile loading #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Drop the '.' in '.ratrc'. Redundant since the parent directory is hidden. Fixes #16. 2. Instead of hardcoding the location of rat's config directory, use $XDG_CONFIG_HOME, following the convention on Unix-like systems. https://en.wikipedia.org/wiki/Freedesktop.org https://specifications.freedesktop.org/basedir-spec/latest In the process I've created a new file for dotfile issues, which may be useful for supporting #17 (loading multiple config files). Open question: should we update the default `flags.cmd`? I've minimally updated it for now, but it's still useless to anyone overriding $XDG_CONFIG_HOME. I'm new to Go, and I don't know how to pass non-literal defaults to flags. I also wonder if the default should be something else.
|
Thanks @akkartik! Mind opening an issue for your open question and folks can discuss there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the '.' in '.ratrc'. Redundant since the parent directory is
hidden. Fixes ratrc should not have a leading dot #16.
Instead of hardcoding the location of rat's config directory, use
$XDG_CONFIG_HOME, following the convention on Unix-like systems.
https://en.wikipedia.org/wiki/Freedesktop.org
https://specifications.freedesktop.org/basedir-spec/latest
In the process I've created a new file for dotfile issues, which may be
useful for supporting #17 (loading multiple config files).
Open question: should we update the default
flags.cmd? I've minimallyupdated it for now, but it's still useless to anyone overriding
$XDG_CONFIG_HOME. I'm new to Go, and I don't know how to pass
non-literal defaults to flags. I also wonder if the default should be
something else.