Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Hardcoded) background color distracting on selection screen #42

Closed
mndscp opened this issue Sep 29, 2022 · 2 comments · Fixed by #44
Closed

(Hardcoded) background color distracting on selection screen #42

mndscp opened this issue Sep 29, 2022 · 2 comments · Fixed by #44

Comments

@mndscp
Copy link

mndscp commented Sep 29, 2022

Are you on latest version of yup?

Yes

Steps to Reproduce the Problem

  1. Install yup
  2. Run yup in any terminal emulator with yup yay or any other parameter
  3. See selection with background too light or too dark

Other Details

Heya, thanks so much, what a good idea, I like yup and would love to use it instead of yay.
I am using Alacritty as my terminal emulator.
It has a dark background with my theme and I would expect the yup selection screen to have the same background color, similar to yay where it does not change at all. I tried in VSCode's terminal emulator and in that the background becomes black instead.

Is the background color hardcoded into yup? Can that setting be removed or made an option in the settings?

Here is a demo, the yay screen is fine, the yup screen is too light:

yup.webm

I hope you can reproduce this and take a look.
Thank you

@mndscp
Copy link
Author

mndscp commented Feb 2, 2023

Found out the background color is the ANSI black color set for the terminal.
Can't yup have no background instead of choosing a font color?

Ballasi added a commit to fourchettes/yup that referenced this issue May 12, 2023
Ballasi added a commit to fourchettes/yup that referenced this issue May 12, 2023
@Ballasi
Copy link
Contributor

Ballasi commented May 12, 2023

I am unsure how I did before when using yup, I don't know the stance of @ericm about adding/keeping the background, but I published a fix that removes that in #44 if you want to try it out.

@ericm ericm closed this as completed in #44 May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants