Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User editable notes for VM and node (wiki?) #98

Closed
dn0 opened this issue Mar 6, 2017 · 5 comments
Closed

User editable notes for VM and node (wiki?) #98

dn0 opened this issue Mar 6, 2017 · 5 comments
Assignees
Milestone

Comments

@dn0
Copy link
Member

dn0 commented Mar 6, 2017

The data (notes) can be stored in existing json fields in DB.

@dn0
Copy link
Member Author

dn0 commented Mar 30, 2017

Feature requested by Alfa Centauri.

@dn0 dn0 added this to the 2.6.0 milestone Mar 30, 2017
@dn0
Copy link
Member Author

dn0 commented Apr 11, 2017

Don't forget about templates if implemented as a new API call.

@ricco386 ricco386 self-assigned this Jun 27, 2017
ricco386 added a commit that referenced this issue Jul 6, 2017
Change was done because we wanted to be consistent with other object
that has note (like snapshots, IPs, etc).
ricco386 added a commit that referenced this issue Jul 6, 2017
Updated node functionality (API, GUI) to be able to save notes. Updated
migration so the note is save in DB.
@ricco386
Copy link
Member

ricco386 commented Jul 6, 2017

Functionality will be done in two phases.

The first phase is going to 2.6.0 release and will contain new text DB fields for VM and node to store note. Updated functionality in API calls: vm/define and node/define to be able to store, show note. GUI has been amended to show this new fields via API calls. Currently, we support only plain text that is escaped.

The second phase will be in 2.7.0 release and will contain text field formatting in some reasonable format. We need to research some JavaScript library, that can format either ReStructured Text, Markdown, or some wiki engine and the user can store formatted text notes, that will be displayed nicely in the GUI (don't forget API validation!). Additionally, add a new screen that can display long text block, and note in details page should be truncated with a link to this new screen.

@dn0 dn0 modified the milestones: 2.7.0, 2.6.0 Jul 6, 2017
ricco386 added a commit that referenced this issue Jul 7, 2017
ricco386 added a commit that referenced this issue Jul 7, 2017
I have also change order of the issues, to be accoring issue numbers
from low to high.
ricco386 added a commit that referenced this issue Jul 7, 2017
The first phase of issue #98 and contain:
* new text DB fields (with migration) for VM and node to store note
* updated functionality in API calls: `vm/define -note <text>` and `node/define -note <text>` to be able to store, show note
* GUI has been amended to show this new fields via API calls
* Currently, we support only plain text that is escaped
* Updated change log with issue #98 (ordered issues numerically)
@ricco386
Copy link
Member

ricco386 commented Jul 7, 2017

The first phase has been done and is part of 2.6.0. See #98 (comment)

ricco386 added a commit that referenced this issue Aug 3, 2017
We shall let users know that they can use markdown so I have updated
the field note.

When there is focus on the text area field it gets larger so is is
easier to edit the text.
ricco386 added a commit that referenced this issue Aug 4, 2017
This way we can escape html, and more importantly javascript in order to prevent XSS, but have nice formatable notes.

Added link to github issue #98 PR #214 in Changelog

Our new template tag markdownify will handle escaping and also marking string safe so there is no need to have safe in template again.

Added new class for markdownify table as other changes were breaking design. Fixed CSS long word wrapping problem. Updated view details to have markhown class that can be styled if necessary...

Updated javascript to improoved UX in issue #98 and PR #214. We shall let users know that they can use markdown so I have updated the field note. When there is focus on the text area field it gets larger so is is easier to edit the text.
@ricco386
Copy link
Member

ricco386 commented Aug 4, 2017

The second phase has been finished and merged in PR #214

@ricco386 ricco386 closed this as completed Aug 4, 2017
@ricco386 ricco386 modified the milestones: 2.6.1, 2.7.0 Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants