Skip to content

Add json format functions for key-value lists #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add json format functions for key-value lists #8889

merged 1 commit into from
Oct 31, 2024

Conversation

isvilen
Copy link
Contributor

@isvilen isvilen commented Oct 2, 2024

Support formatting key-value lists while preserve their ordering.
Closes #8882

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

CT Test Results

    2 files     96 suites   1h 7m 45s ⏱️
2 163 tests 2 115 ✅ 48 💤 0 ❌
2 522 runs  2 472 ✅ 50 💤 0 ❌

Results for commit dd84bb5.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

vkatsuba
vkatsuba reviewed Oct 2, 2024
View reviewed changes
@isvilen isvilen force-pushed the json-format-key-value branch from b03e713 to cebfe51 Compare October 2, 2024 18:35
Maria-12648430
Maria-12648430 reviewed Oct 4, 2024
View reviewed changes
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Oct 4, 2024
dgud
dgud requested changes Oct 8, 2024
View reviewed changes
@isvilen isvilen requested a review from dgud October 10, 2024 06:04
@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Oct 23, 2024
@dgud
Copy link
Contributor

dgud commented Oct 25, 2024

Can you squash the commits and force-push..

@isvilen @vkatsuba @Maria-12648430
Add json format functions for key-value lists
dd84bb5 
Support formating key-value lists while preserve their ordering.

Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Maria Scott <67057258+Maria-12648430@users.noreply.github.com>
@isvilen isvilen force-pushed the json-format-key-value branch from 7a5e64a to dd84bb5 Compare October 25, 2024 11:37
@isvilen
Copy link
Contributor Author

isvilen commented Oct 25, 2024

Can you squash the commits and force-push..

Done, should I also rebase it onto main ?

@dgud dgud removed the testing currently being tested, tag is used by OTP internal CI label Oct 25, 2024
@dgud
Copy link
Contributor

dgud commented Oct 25, 2024

I think you are already based of maint branch.

I could merge it without getting any changes from master, what I saw at least, but could have missed something.
Checked and it looks ok to me, before the squash at least and still good after squash :-)

@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Oct 28, 2024
@dgud dgud changed the base branch from master to maint October 29, 2024 13:16
@dgud dgud merged commit 0f854d9 into erlang:maint Oct 31, 2024
20 checks passed
@isvilen isvilen deleted the json-format-key-value branch October 31, 2024 17:20
williamthome added a commit to williamthome/json_polyfill that referenced this pull request Feb 9, 2025
@williamthome
Add json format functions for key-value lists
433b2b9 
erlang/otp#8889
williamthome added a commit to williamthome/json_polyfill that referenced this pull request Feb 9, 2025
@williamthome
Add json format functions for key-value lists
734786b 
erlang/otp#8889
williamthome added a commit to williamthome/json_polyfill that referenced this pull request Feb 9, 2025
@williamthome
Update and bump to v0.2 (#14)
fae7f23 
* Add a formatter to json

erlang/otp#8511

* Let json:decode/3 keep whitespaces

erlang/otp#8809

* Add json format functions for key-value lists

erlang/otp#8889

* Fix spec for json:format/3

erlang/otp#8914

* Optimize json object encoding

erlang/otp#9251

* Use simple binaries

* Update README.md

* Bump to v0.2

* Act on CI errors

* Always run tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgud dgud dgud approved these changes

+2 more reviewers

@Maria-12648430 Maria-12648430 Maria-12648430 left review comments

@vkatsuba vkatsuba vkatsuba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dgud dgud

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json module format functions for key-value lists
5 participants
@isvilen @dgud @vkatsuba @Maria-12648430 @IngelaAndin