add missing verify_fun mfa translation #9691
Conversation
|
|
CT Test Results 2 files 66 suites 48m 14s ⏱️ Results for commit 8e0adc7. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Discussed in #9692 |
|
Does this documentation require additional revisions? Are there any outstanding concerns preventing merge of this PR? |
|
To me this documentation looks fine. @IngelaAndin; what do you think? |
|
@danj3 ping |
|
@IngelaAndin thanks for the ping. I believe this latest commit addresses the comments. |
IngelaAndin
force-pushed
the
dj/maint-27/dist_verify_fun
branch
from
5abf4f8 to
a5e60f7
Compare
|
Rebased it on OTP-27.3.4 |
|
Typo resolved. |
|
Unfortunately, we cannot accept any contribution unless the GitHub CLA Assistant sees that all contributors have signed our Contributor's License Agreement. @danj3: it seems the commit(s) has got a different e-mail address from the one(s) registered on your GitHub account. So you need to fix that and/or sign the CLA... |
danj3
force-pushed
the
dj/maint-27/dist_verify_fun
branch
from
cae17b3 to
c6ec64c
Compare
|
Thank you for your patience. I believe I have resolved the CLA and author problem both here and in the companion PR for 28. |
add example for verify_fun use in ssl_dist_optfile clarify text and link for verify_fun incompatible legacy use add verify/4 info, change example from if to case
RaimoNiskanen
force-pushed
the
dj/maint-27/dist_verify_fun
branch
from
c6ec64c to
8e0adc7
Compare
|
I rebased to our patch base for maint-27, to satisfy our internal patch scripts. Hopefully I will be able to merge this to maint-28 too and onwards, which should make PR #9692 redundant... This will be the last thing I do before my looong vacation, so fingers crossed ;-) |
inet_tls_dist is missing a configuration translation for verify_fun from an mfa tuple to a closure that can be called during ssl_handshake.
@IngelaAndin This is the missing verify_fun translation I spoke of, for otp-27