ssl: hs_keylog callback properly handle alert in intial states #9849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 66 suites 26m 14s ⏱️ Results for commit c652dc6. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
dgud
previously approved these changes
May 23, 2025
u3s
reviewed
May 23, 2025
u3s
previously approved these changes
May 23, 2025
IngelaAndin
force-pushed
the
ingela/ssl/ERIERL-1235/OTP-19635
branch
from
651710b to
254282f
Compare
That is alerts that happens before any encryption is applied and there is no keys to log. Also add missing maybe_keylog for server when path validation alert is issued for the client certificate chain.
IngelaAndin
force-pushed
the
ingela/ssl/ERIERL-1235/OTP-19635
branch
from
254282f to
c652dc6
Compare
IngelaAndin
added
the
testing
u3s
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is alerts that happens before any encryption is applied and there is no keys to log.
Also add missing maybe_keylog for server when path validation alert is issued for the client certificate chain.