Restore default templates in bootstrapped rebar3 #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When allowing Dialyzer to work internally, we moved a bunch of config (such as no_debug_info) to the prod profile, but the escript included files remained locked onto the default profile. Because the bootstrapping phase now happened in a prod run, the priv/ dirs were never created for the default profile unless a prior run existed, which hid the bug from us. This patch overrides the path on the prod profile so that we don't rely on accidental leftovers for things to work on a bootstrap phase as a dev.
tsloughter
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When allowing Dialyzer to work internally, we moved a bunch of
config (such as no_debug_info) to the prod profile, but the escript
included files remained locked onto the default profile.
Because the bootstrapping phase now happened in a prod run, the priv/
dirs were never created for the default profile unless a prior run
existed, which hid the bug from us.
This patch overrides the path on the prod profile so that we don't rely
on accidental leftovers for things to work on a bootstrap phase as a
dev.
Fixes #1781