properly support top level app erl_opts from REBAR_CONFIG os var #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When REBAR_CONFIG was set it would not effect the top level app's configuration because app_discover was rereading the top level rebar.config which ignored REBAR_CONFIG. Instead this patch has it use the existing configuration from REBAR_CONFIG.
ferd
reviewed
Sep 21, 2018
| AppInfo1 = case ec_file:real_dir_path(rebar_dir:root_dir(State)) of | ||
| AppDir -> | ||
| Opts = rebar_state:opts(State), | ||
| rebar_app_info:default(rebar_app_info:opts(AppInfo, Opts), Opts); |
There was a problem hiding this comment.
alright I guess this is the killer bit -- if the app's path is the same as the project root, use the pre-loaded state, otherwise consult. Am I reading this correctly?
There was a problem hiding this comment.
Right. And note that this function is only called for project apps. So it isn't like it has to do this for dependencies.
ferd
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1860
When REBAR_CONFIG was set it would not effect the top level app's configuration because app_discover was rereading the top level rebar.config which ignored REBAR_CONFIG. Instead this patch has it use the existing configuration from REBAR_CONFIG.
I think it looks like more changes than it really is... The main change is to not reload the
rebar.configfor a top level application from disk. The related opts for a top level app are already read in and parsed into the State.