Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkg name during update by using pkg_name understood by hex #1966

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

aboroska
Copy link
Contributor

@aboroska aboroska commented Dec 2, 2018

Before this fix warnings were displayed during package upgrade when rebar3 and hex package names were different. For example "mixer" / "inaka_mixer". Such deps are specified like:

{deps, [
        {mixer, "1.0.1", {pkg, inaka_mixer}}
 ]}.

On branch master rebar3 upgrade gives:

===> Verifying dependencies...
===> Failed to update package from repo hexpm
===> Failed to fetch updates for package mixer from repo hexpm

Note the package name ("mixer") in the warning message.

After the fix there is no warning.

@ferd ferd merged commit d27eb3a into erlang:master Dec 3, 2018
@aboroska aboroska deleted the fix-upgrade-pkg-name branch December 3, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants