Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate module naming in edoc test suite data #2054

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

tolbrino
Copy link
Contributor

The changes from #2040 would result in the Erlang compiler crashing under the following circumstance:
A set of source files with the same name, but in different source directories, would be compiled in parallel into the same target directory. This is the case for the utility apps used in the edoc test suite.

I suspect before the parallel compilation only one the of the 2 apps has actually been used.

An improvement to rebar_compiler_erl could be to preserve source sub-directories in the target directory structure.

cc @ferd
cc @max-au

@tolbrino
Copy link
Contributor Author

@ferd Could you re-run the failed TravisCI job?

@ferd
Copy link
Collaborator

ferd commented Apr 16, 2019

Yeah, duplicate module names are obviously a problem, so it's possible that the parallel builds made their order non-deterministic. It's fine to fix the test case with renames. Will merge once it passes.

@ferd
Copy link
Collaborator

ferd commented Apr 16, 2019

Yeah I don't get why it keeps repeatedly failing on fetches. Can you rebase on master and see if something there is different to make it work?

@tolbrino
Copy link
Contributor Author

Yeah I don't get why it keeps repeatedly failing on fetches. Can you rebase on master and see if something there is different to make it work?

Tried that, still not working.

@ferd
Copy link
Collaborator

ferd commented Apr 18, 2019

This built fine on my own windows10 machine. I'll assume something is borked with the CI and merge.

@ferd ferd merged commit ec224b7 into erlang:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants