Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output checkouts compilation to _build/<profile>/checkouts/ #2276

Merged
merged 5 commits into from
May 11, 2020
Merged

output checkouts compilation to _build/<profile>/checkouts/ #2276

merged 5 commits into from
May 11, 2020

Conversation

tsloughter
Copy link
Collaborator

Fixes #2275

@tsloughter tsloughter requested a review from ferd May 2, 2020 14:20
ferd
ferd requested changes May 4, 2020
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this breaks rebar3_paths right now since it just goes for deps_dir(State) and manually concatenates for each app name.

The rest looks good.

ferd
ferd approved these changes May 4, 2020
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkouts in paths actually never worked, so this shouldn't be a blocker

@tsloughter tsloughter merged commit 2e5c2c9 into erlang:master May 11, 2020
@ferd ferd mentioned this pull request Aug 1, 2022
Open
@ferd ferd mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should _checkouts output to _build
2 participants
@tsloughter @ferd