Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erl_interface from makefile template #2331

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Aug 22, 2020

fixes #2323

@ferd ferd requested a review from tsloughter August 22, 2020 20:54
@tsloughter
Copy link
Collaborator

But shouldn't it be there if its not otp-23?

@garazdawi
Copy link
Contributor

Most nifs/ports to not need to link with ei or erl_interface, so I would argue that if the user needs it she should add it in LIBS.

@ferd
Copy link
Collaborator Author

ferd commented Aug 25, 2020

But shouldn't it be there if its not otp-23?

Yeah though I just assumed that since it's a template we're not gonna break anything from existing projects, so a hard removal there wouldn't be the hardest thing.

@tsloughter tsloughter merged commit 390421e into erlang:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTP23 default Makefile template links erl_interface
3 participants