OTP-24 Readiness #2459
Merged
OTP-24 Readiness #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces (deprecated in OTP 25) http_uri calls with uri_string.
and use it to avoid a warning in ./bootstrap.
as it won't be available. While at it, log errors and more relevant resolution information at debug level.
This does not get rid of all warnings. This fixes the HiPE dependency to be conditional to whether dialyzer actually requires it or not, and makes use of the .app.src.script feature internally, at build time. This may cause issues for scripts built prior to OTP-24 being used for OTP-24 versions as it will ask for apps that aren't in place, but there's no good work-around for that. This also bumps the erlware-commons version to one that eliminates some warnings, and makes the bootstrap script honor the warnings_as_errors value of dependencies to allow the build to proceed until parse_trans is fixed upstream.
…elklishin/rebar3 into michaelklishin-mk-uri-string-in-bootstrap
tsloughter
approved these changes
Jan 7, 2021
|
Can this be backported to a |
|
We shouldn't be backporting anything, but we should probably cut a new release soon. Last release was almost 2 months ago. |
|
FTR, this was included into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @michaelklishin for the following fixes
I've also added a fix for the HiPE deprecation in OTP-24 to be conditional to whether dialyzer actually requires it or not, and makes use of the .app.src.script feature internally, at build time. This may cause issues for scripts built prior to OTP-24 being used for OTP-24 versions as it will ask for apps that aren't in place, but there's no good work-around for that, and would only break on the Dialyzer command.
This supercedes #2452