Add new 'shell_hooks_env' config to extend shell hooks' OS env vars #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option requires a list of Name-Value pairs that are set as env variables when calling the hooks.
ferd
requested changes
Sep 19, 2023
apps/rebar/src/rebar_env.erl
Outdated
| @@ -58,7 +58,8 @@ create_env(State, Opts) -> | |||
| {"ERLANG_TARGET", rebar_api:get_arch()} | |||
| ], | |||
| EInterfaceVars = create_erl_interface_env(), | |||
| lists:append([EnvVars, EInterfaceVars]). | |||
| ConfigVars = rebar_state:get(State, env, []), | |||
There was a problem hiding this comment.
we're gonna need a far more descriptive name for this option, especially since rebar_env is called exclusively for hooks right now, and that env can also refer to application or release environment values.
A name like shell_hooks_env would likely be the most descriptive and narrow definition. hooks_env could work but could be confusing for provider hooks rather than shell hooks. env_hooks would fit the overall config pattern but is sort of a stretch as well.
Either way, we need something narrower and more specific than just env here.
There was a problem hiding this comment.
I have no problem with shell_hooks_env
ferd
approved these changes
Sep 19, 2023
ferd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option requires a list of Name-Value pairs that are set as env variables when calling the hooks.
{env, [{"MY_VAR", "my-value"}]}.I tried to add a test in the hooks suite, I do not know if there is a better place.