-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 'or' in versions in a primitive manner #2840
Conversation
@ferd @tsloughter Would something like this have any chance of getting merged? It sidesteps the whole "requirement vs version" and |
Yeah I'd be willing to get an in-between patch where |
Good, anything I should add or change before this can be merged? The failure on macOS was due to brew not getting updates, rerunning it is probably enough. |
Yeah I think I'd like a test that runs on versions like |
The first constraint in a chain of "or"'d constraints is taken into account, all others are ignored. That way, there is at least *some* resolution happening, which can always be overridden via `rebar.config`.
7bc272d
to
7808065
Compare
Finally got around to adding tests (and "fixing" the exact issue that you may have been hinting at ;)). |
7808065
to
7194cba
Compare
7194cba
to
ae0c00f
Compare
@ferd The only error here is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep thanks for the edit, and yeah the brew thing is known breakage I need to look at. Merging this!
The first constraint in a chain of "or"'d constraints is taken into
account, all others are ignored. That way, there is at least some
resolution happening, which can always be overridden via
rebar.config
.