Dedupe compiler DAG edge insertion for artifacts #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue described at https://erlangforums.com/t/rebar3-is-taking-longer-to-compile-projects/3061/13 It appears that edge insertion with a label involved messes with the bag table and continuously inflates the size of a DAG after many runs. Since changes are propagated through a graph, frequent changes to often-included header files or parse transforms risk multiplying edge counts. This little patch ensures that before inserting an artifact edge, we first look whether it already exists; if so we don't add it any further, but keep all other semantics the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue described at https://erlangforums.com/t/rebar3-is-taking-longer-to-compile-projects/3061/13
It appears that edge insertion with a label involved messes with the bag table and continuously inflates the size of a DAG after many runs. Since changes are propagated through a graph, frequent changes to often-included header files or parse transforms risk multiplying edge counts.
This little patch ensures that before inserting an artifact edge, we first look whether it already exists; if so we don't add it any further, but keep all other semantics the same.