Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto:rand_bytes/1 was removed in 20.0+ #14

Closed
wants to merge 1 commit into from

Conversation

danieljharris
Copy link

_build/default/lib/lhttpc/src/lhttpc_manager.erl:270: Warning: call to crypto:rand_bytes/1 will fail, since it was removed in 20.0; use crypto:strong_rand_bytes/1

_build/default/lib/lhttpc/src/lhttpc_manager.erl:270: Warning: call to crypto:rand_bytes/1 will fail, since it was removed in 20.0; use crypto:strong_rand_bytes/1
@nalundgaard
Copy link

Ignore the warning. It's there for compatibility. Read the code: it's a fallback.

@nalundgaard nalundgaard closed this May 4, 2018
@nalundgaard
Copy link

@danieljharris just for clarity: the guard lists:member({seed,1}, ssl:module_info(exports)) is always false for Erlang 20. It looks like the function was removed in R15, actually, the last tag I see with it is OTP_R14B04.

So this is harmless. @motobob should we just delete this whole block?

@motobob
Copy link

motobob commented May 4, 2018

yeah, let's clean it all up. R16 is the oldest thing i care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants