allow master defaults in connect #19
Conversation
|
@nalundgaard take a look. purposed on this is straight forward. motivation simplify life for erlcloud users like us |
src/lhttpc_client.erl
Outdated
| infinity), | ||
| connect_options = proplists:get_value(connect_options, Options, []), | ||
| connect_timeout = proplists:get_value(connect_timeout, Options, DefConTimeout), | ||
| connect_options = proplists:get_value(connect_options, Options, DefConOptions), |
There was a problem hiding this comment.
connect_options is a list. so for me it looks natural to merge DefConOptions and connect_options from Options, but not drop all DefConOptions in case any option is passed to execute() call.
current version will increase entropy of the universe.
There was a problem hiding this comment.
fair enough. agree. will make it soon
src/lhttpc_client.erl
Outdated
| @@ -150,6 +150,9 @@ execute(From, Host, Port, Ssl, Path, Method, Hdrs0, Body, Options) -> | |||
| %% Get a socket for the pool or exit | |||
| %Socket = lhttpc_manager:ensure_call(Pool, SocketRequest, Options), | |||
| Socket = lhttpc_manager:ensure_call(Pool, self(), Host, Port, Ssl, Options), | |||
| % get the socket connect settings from client or use defaults | |||
| DefConOptions = application:get_env(lhttpc, connect_options, []), | |||
| DefConTimeout = proplists:get_value(DefConOptions, connect_timeout, infinity), | |||
There was a problem hiding this comment.
This looks backwards. Please change to proplists:get_value(connect_timeout, DefConOptions, infinity).
src/lhttpc_client.erl
Outdated
| infinity), | ||
| connect_options = proplists:get_value(connect_options, Options, []), | ||
| connect_timeout = proplists:get_value(connect_timeout, Options, DefConTimeout), | ||
| connect_options = proplists:get_value(connect_options, Options, DefConOptions), |
|
tested as
|
* Adds support for defaulting lhttpc connect_options via the OTP app configuration; see erlcloud/lhttpc#19
allow setting defaults for connect options once in config and note upon every request.