Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rebar3 for building/tests on repo #28

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Use rebar3 for building/tests on repo #28

merged 2 commits into from
Jul 18, 2024

Conversation

rmpalomino
Copy link

  • Use rebar3 for building/tests on repo

This does not remove support for rebar2 projects to pull in the library, it just uses rebar3 for building/testing when cloning this repository itself. Pulls in commits from #27 which assumes rebar3 is used to run tests.

dw-kihara and others added 2 commits June 5, 2024 08:11
- addressed deprecated ssl:ssl_accept
- fixed several option values
- added options to suppress cert verification
- renewed the test cert/key
@rmpalomino rmpalomino mentioned this pull request Jul 17, 2024
Copy link

@cody-friedrichsen cody-friedrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@dw-kihara
Copy link

Looks good to me except for my own commit, which should be reviewed by others.

@rmpalomino rmpalomino merged commit 179963e into master Jul 18, 2024
@rmpalomino rmpalomino deleted the rebar3 branch July 18, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants