Feature/task execution

[clemens-tolboom]

Meta

Issue worked on

#275

Branch

https://github.com/ErmiyaEskandary/Slither.io-bot/tree/feature/task-execution

Description

As discussed in #266 but not completed yet here is my first stab.

My basic implementation uses a tasks list with priorities. I have added a few task

• CheckForFood: Trigger food scan. It has a changing priority to allow other tasks to be performed.
• MoveToXY move to the given waypoint
• AvoidCollisionEnemySnake: Avoid collision with other (enemy) snakes. It using existing code.
• ListTasks: List the current set of tasks. Has lowest priority

Motivation and Context

Problem

Adding new behaviour is difficult as this is hard coded. With A* it was still coded but easier to add new behavior. Furthermore we have a check for food triggered by a window timer which makes it harder too. It is not possible to add behaviour by another user script either.

Solution

This branch decouples the code

// Main bot
go: function() {

by replacing the parts mentioned above into a task scheduler. This allows for prioritise / (de)activate / adding tasks so the behaviour is more dynamic and alterable from outside this project (ie console).

It adds menu entries to toggle tasks to test particular behaviour.

Features

// Activate task
window.scheduler.getTask('MoveToXY').active = true;

// Set new point
window.scheduler.getTask('MoveToXY').point = {x: 21600, y: 21600};

// Prepare a new Task
var newTask = window.scheduler.newTask('dummy')

// Add new task
window.scheduler.addTask(newTask);

// Cannot add duplicate task ID
window.scheduler.addTask(window.scheduler.newTask('dummy'));

// Delete task
window.scheduler.deleteTask('dummy');

// Report on tasks
window.scheduler.getTask('ListTasks').execute();

Task list

window.scheduler.listTasks()

CheckForFood Active: true Priority: 397 Trigger food scan
AvoidCollisionEnemySnake Active: true Priority: 0 Avoid collision with other (enemy) snakes
_default Active: true Priority: 0 This is the default task which cannot be deactivated.
MoveToXY Active: false Priority: 300 Move to the given way point

Screenshots (if appropriate):

Menu

MoveToXY

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code adheres to the code style of this project but most importantly of all to the things mentioned in CONTRIBUTING.md and PULL_REQUEST_TEMPLATE.md.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

TODOs

• Fix priority for MoveToXY (stop when reached; lower priority when nearing P(x,y)?
• MoveToXY is now hard coded as move to center and never looses priority. It makes the bot reaching center.
• Add surround algorithm from A* branch
• Add more from A* branch
• Receive lots of feedback
• Provide task getter function getTaskByID
• Add default task
• Remove ListTasks as that is no actual task
• Add task.active boolean
• Check task structure so far.
• Add schedule.init() when entering game
• Do not set target while checking for collisions #285 Create issue when PR lands regarding __ AvoidCollisionEnemySnake __ as mentioned in WIP: Initial task oriented example. #275 (comment)
• Split collision detection into snake collision and wall collision #284 Create issue when PR lands to split collision snake and wall

[houndci-bot]

Expected no return value.

[clemens-tolboom]

Thanks @houndci-bot :p

[ermiyaeskandary]

checkforfood checks for food and eats it.
There's no point for eat.

• eat doesn't work if checkforfood isn't enabled/on :(

[ermiyaeskandary]

I presume for testing this - 3 options, which have to be and are present in the current master bot, **only need to be enabled:

• avoidcollisionenemysnake
• checkforfood

(eat) may be one if the bug ^^^ is addressed or simply just remove it .... @clemens-tolboom

[ermiyaeskandary]

@clemens-tolboom The overlay is also messed up - the scores don't fully show up

[ermiyaeskandary]

@clemens-tolboom

Below some results without MoveToXY which are not good I guess :-(

Solved ?

[ChadSki]

Running tests...

1. feature/task-execution (23aeb46)
2. develop (10dfdb6)

[ermiyaeskandary]

@ChadSki What options are you testing with for feature/task-execution ?

[ChadSki]

Defaults

[ermiyaeskandary]

@ChadSki 👍

[ChadSki]

It's only been two hours so far, but the results are not looking so great. Current medians below:

1. feature/task-execution (23aeb46)
   • 4711 (11 games)
   • 1654 (9 games)
   • 3548 (11 games)
   • 1601 (16 games)
2. develop (10dfdb6)
   • 6410 (14 games)
   • 4877 (13 games)
   • 4727 (9 games)
   • 9815 (6 games)

I'll keep the test running overnight, though.

[ChadSki]

This pull request has been open for over a month. I think it's best if development happens on the separate branch until it is truly ready for integration.

[clemens-tolboom]

You made me very nervous closing this PR so I pushed my code to git@github.com:clemens-tolboom/Slither.io-bot.git

Note the issue summary has a separate branch https://github.com/ErmiyaEskandary/Slither.io-bot/tree/feature/task-execution but only I am working on it which s**ks

Guess this is goodbye

[ChadSki]

Nervous? The code doesn't go away, if that's what you meant -- the feature/task-execution branch has all your changes intact.

I like to follow your progress but pull requests are really about "I'm ready to merge, can anyone review my changes?" Since this branch isn't ready to be pulled/integrated, it shouldn't be a PR yet.

It's very easy to open a PR so I would recommend doing so once everything is ready for review.