Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Typescript, TSX and JSX files #564

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

adrien-f
Copy link
Contributor

@adrien-f adrien-f commented Feb 8, 2023

Greetings 👋

While taking Vale for a drive, I could not get it to properly lint our Typescript and React files that contain docstrings.

Let me know what you think 🤗

Signed-off-by: Adrien Fillon adrien.fillon@manomano.com

@jdkato
Copy link
Member

jdkato commented Feb 11, 2023

This will work for TypeScript, but TSX/JSX will need test cases in testdata/fixtures/formats.

Signed-off-by: Adrien Fillon <adrien.fillon@manomano.com>
@adrien-f
Copy link
Contributor Author

Hi @jdkato !

Thanks for your input, I've added a dedicated JSX file, let me know how's that looking!

✦ ❯ vale --output=line --sort --normalize --relative test.jsx
test.jsx:1:4:vale.Annotations:'XXX' left in text
test.jsx:4:6:vale.Annotations:'NOTE' left in text
test.jsx:14:3:vale.Annotations:'XXX' left in text
test.jsx:18:39:vale.Annotations:'TODO' left in text

@jdkato
Copy link
Member

jdkato commented Feb 16, 2023

Thanks -- this looks good!

@jdkato jdkato merged commit 96aced2 into errata-ai:v2 Feb 16, 2023
@adrien-f adrien-f deleted the ts-support branch February 17, 2023 09:46
@aisamu aisamu mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants