Allow non-standard hipchat server #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass in server specified in the config to allow connection to a hosted hipchat server
|
Thanks! This shouldn't actually be required (I think) because your JID should already include the correct domain even with HipChat server (please correct me if I'm wrong), but nontheless we should support this to be consistent with the XMPP backend. I've merged this but ended up rebasing it in my how-I-deal-with-PRs-at-work mindset so the commit hash changed. 😄 It's in as 959798e now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass in server specified in the config to allow connection to a hosted hipchat server