Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions CI. #39

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Switch to GitHub Actions CI. #39

merged 2 commits into from
Sep 30, 2019

Conversation

XhmikosR
Copy link
Collaborator

No description provided.

@rakeshpai rakeshpai marked this pull request as ready for review September 21, 2019 10:03
@XhmikosR
Copy link
Collaborator Author

CI doesn't seem to fire up for the repo. We might need to contact GH Support.

@rakeshpai
Copy link
Member

Could it be that the the yml needs to be in the repo (not just a PR) for it to work?

@XhmikosR
Copy link
Collaborator Author

It shouldn't matter, it should still fire up.

@rakeshpai
Copy link
Member

The actions tab at the top makes it pretty clear that it's not configured yet though, which I why I think it might be worth just merging this to see what happens.

@XhmikosR
Copy link
Collaborator Author

No, it shouldn't be merged. The Actions should fire up in this PR.

@rakeshpai
Copy link
Member

Ok. Contacted support. I'll update this thread when I hear back.

@XhmikosR
Copy link
Collaborator Author

@rakeshpai this could be because I'm not an org collaborator, I just have push rights to this repo and for security reasons Actions don't run in this case.

We can merge it and see how it goes.

@rakeshpai rakeshpai merged commit 535ecdc into master Sep 30, 2019
@rakeshpai rakeshpai deleted the gh-actions branch September 30, 2019 18:33
@rakeshpai
Copy link
Member

Looks like it did the trick!

@XhmikosR
Copy link
Collaborator Author

Perfect :)

I removed Travis from the repo.

@XhmikosR
Copy link
Collaborator Author

BTW can you check the repo hooks? It seems there's one hook left that's failing. If it's not used, better remove it.

@rakeshpai
Copy link
Member

Deactivated the hook. No idea what that was doing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants