Skip to content
This repository has been archived by the owner on Jun 30, 2024. It is now read-only.

setqftitle: documentation/reference; maybe include the patch in a contrib dir? #3

Open
blueyed opened this issue Dec 12, 2013 · 3 comments

Comments

@blueyed
Copy link
Contributor

blueyed commented Dec 12, 2013

There is the following code in plugin/ag.vim:

if exists('*setqftitle')
  call setqftitle('ag' . args)
endif

I wondered where it might come from, and then found a mailing list thread about it:
https://groups.google.com/d/msg/eclim-dev/_FGmSoZ24ak/Bl1Jc1eFI1QJ

It still applies (except for the syntax hunk).

Is this still the latest patch?
Have you proposed it for inclusion in Vim?

btw, there's a warning when building:

eval.c: In function ‘f_getqftitle’:
eval.c:11784:26: warning: assignment makes pointer from integer without a cast [enabled by default]
     rettv->vval.v_string = get_errortitle(wp);
                          ^
@ervandew
Copy link
Owner

I never got around to fixing the warning, but there was another patch posted to vim-dev that, after some changes, looks to be a better alternative to mine:

https://groups.google.com/d/msg/vim_dev/X7VVPd4Do5s/svKaV6Eah6YJ

It is in vim's ever growing todo list:

Patch to allow setting w:quickfix_title via setqflist() and setloclist()
functions. (Christian Brabandt, 2013 May 8, update May 21)

I need to update ag and eclim to both use the new patch's method for when it is hopefully merged into vim.

blueyed added a commit to blueyed/ag that referenced this issue Dec 13, 2013
@blueyed
Copy link
Contributor Author

blueyed commented Dec 13, 2013

Ah.. I have came across that thread a while ago.

But I noticed that given your patch, ag causes an error:

Error detected while processing function <SNR>29_Ag:                                                                                                                      
line   58:                                                                                                                                                                
E730: using List as a String                                                                                                                                              
E116: Invalid arguments for function setqftitle

ervandew added a commit that referenced this issue Dec 13, 2013
Christian Brabandt submitted[1] a patch to vim-dev for setting a
persistent qf title which is now on the vim todo list. So, remove the
code which uses my patch and replace it with a commented out version of
code which can be enabled if/when Christian's patch is applied.

[1] https://groups.google.com/d/msg/vim_dev/X7VVPd4Do5s/svKaV6Eah6YJ

refs #3
blueyed added a commit to blueyed/ag that referenced this issue May 7, 2015
blueyed added a commit to blueyed/ag that referenced this issue May 8, 2015
@blueyed
Copy link
Contributor Author

blueyed commented Feb 25, 2016

It has landed in Neovim finally: neovim/neovim#4337 (not yet in Vim)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants