[Solidity] Tuple Support #1647
Draft
[Solidity] Tuple Support #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync Forked Repo With Main Repo
…or Continue and Break
Rebase
| @@ -2602,7 +2830,7 @@ bool solidity_convertert::get_func_decl_ref( | |||
| exprt &new_expr) | |||
| { | |||
| // Function to configure new_expr that has a +ve referenced id, referring to a function declaration | |||
| // This allow to get func symbol before we add it to the symbol table | |||
| // This allow to get func syfmbol before we add it to the symbol table | |||
| return output; | ||
| } | ||
|
|
||
| std::vector<nlohmann::json> solidity_convertert::make_struct_elementary_types( |
There was a problem hiding this comment.
I think you can obtain the type info in the typeDescriptions node in each component, right?
You can do something like:
if (get_expr(args.at(i), members.at(i)["typeDescriptions"], init))
return true;There was a problem hiding this comment.
I have yet to delete this function in case I may use it in the future for an unknown reason. I will delete it shortly
| std::string label = std::to_string(expr["id"].get<int>()); | ||
| std::string name, id; | ||
| name = "tuple#" + label; | ||
| id = "sol:@C@" + current_contractName + "@" + name; |
| // e.g. (uint age, uint money) = (....); | ||
| if(context.find_symbol(id) != nullptr) | ||
| { | ||
| std::cout << "Could not find symbol" << std::endl; |
There was a problem hiding this comment.
Maybe just log_error
| @@ -40,7 +41,7 @@ solidity_convertert::solidity_convertert( | |||
|
|
|||
| bool solidity_convertert::convert() | |||
| { | |||
| // This function consists of two parts: | |||
| // This function consists of two output: | |||
There was a problem hiding this comment.
I think we keep the word "parts"
|
Overall, it looks good. Just some small comments:
contract Base
{
uint x;
bool y;
constructor() { (x,y) = (1,true); }
}
contract Derived is Base
{
function test() public
{
assert(y == true);
}
} |
Tuple support
Merge branch 'esbmc:master' into tuple_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.