Introduce Machinery for Servicing STUN Parameters @ A Semantic Level #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dzol
commented
Jan 25, 2017
| case class(p) do | ||
| :request -> | ||
| Fennec.Evaluator.Request.service(p, changes) | ||
| :_ -> |
Dzol
force-pushed
the
service-machinery
branch
from
257f132
to
19eee56
Compare
arkgil
approved these changes
Jan 27, 2017
| defmodule Fennec.Evaluator do | ||
| @moduledoc """ | ||
|
|
||
| Common to ALL TURN/STUN. E.g. authentication. |
There was a problem hiding this comment.
We should remove whitespaces around that line
There was a problem hiding this comment.
I'm thinking, do we need a moduldoc for this module? It will only be used internally, we won't expose this API to users, right?
| @@ -0,0 +1,49 @@ | |||
| defmodule Fennec.Evaluator.Request do | |||
| @moduledoc """ | |||
There was a problem hiding this comment.
The same thing with docs as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general way to service all kinds of STUN message: STUN methods, attributes, and servicing that's applicable to all kinds of STUN message classes can be added easily and understandably.