Update dev release docs / configs
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `config/dev.exs` connect by default to local mocks that can be setup the same way as for tests.
README.md now includes information aboout building `dev` release that connects to local APNS / FCM mocks.
rslota
commented
Nov 6, 2019
| use_2197: true, | ||
| pool_size: 5 | ||
| pool_size: 5, | ||
| tls_opts: [] |
There was a problem hiding this comment.
This option is here, as recently MongoosePush started validating APNS / FCM server certs by default. As for dev release we expect to be connecting to mocks, we need to disable the verification, as otherwise the release won't boot.
There was a problem hiding this comment.
Maybe we can add this option to the list here: 7983a85#diff-04c6e90faac2675aa89e2176d2eec7d8R194 ?
zofpolkowska
approved these changes
Nov 6, 2019
rslota
added a commit
that referenced
this pull request
Nov 21, 2019
* Update config/dev.exs Make `config/dev.exs` connect by default to local mocks that can be setup the same way as for tests. * Update README.md README.md now includes information aboout building `dev` release that connects to local APNS / FCM mocks. * Update config files documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config/dev.exsconnect by default to local mocks that can besetup the same way as for tests.
devrelease thatconnects to local APNS / FCM mocks.