Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller/Return a more explicit running status from #171

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

NelsonVides
Copy link
Collaborator

This way the map has keys with proper names for the fields we're looking at.

@NelsonVides NelsonVides changed the title Return a more explicit running status from the controller Controller/Return a more explicit running status from Dec 16, 2023
Base automatically changed from controller/tests to master December 17, 2023 14:59
@NelsonVides NelsonVides force-pushed the controller/return_more_explicit_status branch from 7f1b6b9 to 8590a36 Compare December 19, 2023 09:26
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9459926) 47.58% compared to head (8590a36) 47.58%.

Files Patch % Lines
src/amoc.erl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   47.58%   47.58%           
=======================================
  Files          23       23           
  Lines         975      975           
=======================================
  Hits          464      464           
  Misses        511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides marked this pull request as ready for review December 19, 2023 23:38
Copy link
Contributor

@jacekwegr jacekwegr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@jacekwegr jacekwegr merged commit c4d5859 into master Jan 3, 2024
6 checks passed
@jacekwegr jacekwegr deleted the controller/return_more_explicit_status branch January 3, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants