Controller/Deduplicate user supervision #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
changed the title
NelsonVides
changed the base branch from
controller/return_more_explicit_status
to
controller/tests
NelsonVides
changed the base branch from
controller/tests
to
controller/return_more_explicit_status
NelsonVides
force-pushed
the
controller/return_more_explicit_status
branch
from
7f1b6b9
to
8590a36
Compare
NelsonVides
force-pushed
the
controller/dedup_supervision
branch
from
93a5470
to
a906215
Compare
Base automatically changed from
controller/return_more_explicit_status
to
master
January 3, 2024 13:40
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
===========================================
+ Coverage 47.64% 73.62% +25.97%
===========================================
Files 23 29 +6
Lines 976 1069 +93
===========================================
+ Hits 465 787 +322
+ Misses 511 282 -229 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
controller/dedup_supervision
branch
from
a906215
to
08e0aae
Compare
In the original implementation, the process is monitored by two supervisors, the original amoc_users_sup, and the amoc_controller one. But this means that bursts of ups and downs overflow the mailbox of _two_ processes, one of them being actually the very critical controller. With this reimplementation, only the amoc_users_sup tracks the processes, and all requests from the controller are asynchronous. This ensures the controller does not get blocked and can remain responsive to control requests.
NelsonVides
force-pushed
the
controller/dedup_supervision
branch
from
08e0aae
to
126ffb6
Compare
Merged
|
Done in #175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation, the process is monitored by two supervisors, the original amoc_users_sup, and the amoc_controller one. But this means that bursts of ups and downs overflow the mailbox of two processes, one of them being actually the very critical controller.
With this reimplementation, only the amoc_users_sup tracks the processes, and all requests from the controller are asynchronous. This ensures the controller does not get blocked and can remain responsive to control requests.