Skip to content

feat: drop Node 8 & 10 support #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022
Merged

feat: drop Node 8 & 10 support #16

merged 1 commit into from
Dec 30, 2022

Conversation

MichaelDeBoey
Copy link
Member

BREAKING CHANGE: Requires Node@^12.0.0 || ^14.0.0 || ^16.0.0 || ^18.0.0

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Nov 28, 2022
@MichaelDeBoey MichaelDeBoey requested a review from a team November 28, 2022 11:30
@MichaelDeBoey MichaelDeBoey self-assigned this Nov 28, 2022
@ota-meshi
Copy link
Member

Can we use --legacy-peer-deps to temporarily avoid the error?

@MichaelDeBoey
Copy link
Member Author

I'm wondering why we all of a sudden get these failures as we were already testing against these versions before 🤔

@ota-meshi
Copy link
Member

README.md also seems to have a description of the supported versions. Could you please correct this as well?

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts

Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't approve of "node": "^12.0.0 || ^14.0.0 || ^16.0.0 || ^18.0.0"

BREAKING CHANGE: Requires Node@^12.0.0 || ^14.0.0 || ^16.0.0 || >=18.0.0
@MichaelDeBoey MichaelDeBoey merged commit c0a6702 into main Dec 30, 2022
@MichaelDeBoey MichaelDeBoey deleted the patch-10 branch December 30, 2022 18:54
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants