-
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: drop Node 8 & 10 support #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f10e265
to
cf6cb22
Compare
Can we use |
I'm wondering why we all of a sudden get these failures as we were already testing against these versions before 🤔 |
cf6cb22
to
7da6dba
Compare
README.md also seems to have a description of the supported versions. Could you please correct this as well? |
7da6dba
to
569930b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't approve of "node": "^12.0.0 || ^14.0.0 || ^16.0.0 || ^18.0.0"
BREAKING CHANGE: Requires Node@^12.0.0 || ^14.0.0 || ^16.0.0 || >=18.0.0
569930b
to
a0aeacd
Compare
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Requires Node@^12.0.0 || ^14.0.0 || ^16.0.0 || ^18.0.0