Skip to content

Conversation

skyclouds2001
Copy link

@skyclouds2001 skyclouds2001 commented Apr 2, 2025

it is a descriptor of @font-face at-rule, not a CSS property; so it should not be patched here

this mirrors csstree#330

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Apr 2, 2025
@skyclouds2001 skyclouds2001 marked this pull request as ready for review April 2, 2025 17:05
@nzakas
Copy link
Member

nzakas commented Apr 2, 2025

Should font-face be patched?

@skyclouds2001
Copy link
Author

Should font-face be patched?

https://github.com/mdn/data/blob/ad5e352161f5ed7b129741f5e1169cab8e89a05d/css/at-rules.json#L253-L262

since its version is as the same as the mdn-data@v2.18.0's version, I think it is no need to patch it

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14243107764

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.601%

Totals Coverage Status
Change from base Build 14227350222: 0.0%
Covered Lines: 11671
Relevant Lines: 11803

💛 - Coveralls

@fasttime fasttime added this to Triage Apr 4, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 4, 2025
@nzakas
Copy link
Member

nzakas commented Apr 4, 2025

Sounds good. Thanks.

@nzakas nzakas merged commit e3d17f0 into eslint:main Apr 4, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Apr 4, 2025
@github-actions github-actions bot mentioned this pull request Apr 4, 2025
@skyclouds2001 skyclouds2001 deleted the src branch April 4, 2025 18:54
nzakas pushed a commit that referenced this pull request Jun 2, 2025
* fix: Remove `src` descriptor patch

* fix: remove test for src as a property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants