fix: consider negated patterns universal

[mdjermanovic]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request?

Fixes the problem described in eslint/eslint#19813.

What changes did you make? (Give an overview)

Updated regex pattern that checks for universal patterns to treat negated patterns as such.

Related Issues

eslint/eslint#19813

Is there anything you'd like reviewers to focus on?

[mdjermanovic]

This test was added in #7, where part of the change was to update isFileIgnored() to return true only if the file is "really" ignored, that is, ignored by ignore patterns and not just unmatched. I think the test was added to correlate with a similar test for isFileIgnored(), and was rather describing the current behavior at the time than insisting that the behavior is correct in this case.

[mdjermanovic]

On the other hand, tests for isIgnored methods with a .docx file, that were added at the time when unmatched files were considered the same as ignored, were asserting that this filename should not be ignored, i.e., that it should be matched, so that might have been the intent.

Here's the commit that added the original test with a .docx file:

humanwhocodes/config-array@343e5a0#diff-1191860929aeaa1bf678ce5c01f7f18dfe40a70ef71105a86b2f4ea95859016aR616-R620

It's interesting that the test description says true but then asserts that it is false.

it('should return true when passed docx filename', () => {
	const filename = path.resolve(basePath, 'sss.docx');

	expect(configs.isIgnored(filename)).to.be.false;
});

[fasttime]

Yes, in that test getConfigStatus is returning "matched" because one of the config objects contains a negated pattern, which is being treated as a non-universal match according to the current logic:

rewrite/packages/config-array/tests/config-array.test.js

Lines 82 to 87 in e84cbd7

	{
	files: ["!*.css"],
	defs: {
	css: false,
	},
	},

This was the expected behavior prior to this fix.

[nzakas]

LGTM. Would like @fasttime to review before merging.

[fasttime]

LGTM, thanks!