chore: hoist cli tools to root level #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
changed the title
lumirlumir
changed the title
nzakas
reviewed
Jun 10, 2025
| "rollup": "^4.16.2", | ||
| "rollup-plugin-copy": "^3.5.0", | ||
| "typescript": "^5.4.5" | ||
| "rollup-plugin-copy": "^3.5.0" |
There was a problem hiding this comment.
Should we also move rollup-plugin-copy to the root? It's used in a bunch of the packages.
There was a problem hiding this comment.
Thanks for your suggestion. However, unfortunately, if we remove rollup-plugin-copy from the devDependencies, it shows an ESLint error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I’ve hoisted CLI-related packages to the root level and bumped their versions to the latest. This is a follow-up to eslint/js#650.
The following packages have been hoisted:
typescriptmochac8rollupThese packages are only used in CLI tools, so it would be safe to hoist them.
Some of the packages include major version updates, but the breaking changes are limited to updated Node.js version requirements, so it’s safe to upgrade them.
What changes did you make? (Give an overview)
I’ve hoisted CLI-related packages to the root level and bumped their versions to the latest.
The benefit of hoisting packages to the root level is well described in eslint/js#650
Related Issues
Reference: eslint/js#650
Is there anything you'd like reviewers to focus on?