ISSUE-9: Implement immediate processing via Batch #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And more will need to follow
Heavily inspirited on the queue_ui. I may clean this up more and simplify. Works on a per Set queue that does not have its own queue worker, which is on purpose so it can never be processed by Cron or QUEUE_UI, but will borrow during interactive Batch the ami_ingest_ado worker and do its "thing" TODO: add locking mechanism so never two sets can be processed at the same time
Not used, the queue worker does the work
.. and start thinking this one needs to deal with all operations. Will create private methods for that
@alliomeria i also changed some wording and make some of the checkboxes/more clean. Immediate Batch processing works perfect now!
DiegoPino
added
enhancement
|
Hello @DiegoPino, this worked great during testing. It felt nice, smoother to have the option to ingest immediately, and the language you added/adjusted explaining the Enqueue process is clear and helpful. Awesome! :) |
|
Thanks @alliomeria for testing, now it is merged. Now onto ZIP implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9
This is working, I will do some more cleanup and improve the queue worker to deal with the other 3 operations as well. Can be tested already @alliomeria