ISSUE-124: Inherit right "defineDefaultBaseProperties" for LoD webform elements #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoPino
added
bug
JSON cached response in the future. Only reason we go for this is to have more control but we may not need it Also. If the call is internal (who calls == same as the server and there is no session we do bypass the 5 seconds wait per call) `@TODO:` Too much of a fuzz to call URLs and Routes for internal calls. We may want to have public methods (not a controller?) for every LoD reconciliation endpoint for 1.1.x or 1.2.x
This basically fixes errors but does not ensure we have it all right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #124
Each webform element has some inherited base properties, we neglected on inheriting the right ones when overriding the defaults disabling because of the that a Access and also Advanced tab properties used to configured element instances in a webform
This pull should fix the issue and goes into RC3
@giancarlobi you want to update once its merged and @dmer @patdunlavey you want to test and see if all is working afterwards.