Skip to content

Update clap to stable version, reset baud when starting serial monitor #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2022
Merged

Update clap to stable version, reset baud when starting serial monitor #125

merged 2 commits into from
Jan 26, 2022

Conversation

jessebraham
Copy link
Member

  • Move off of the clap release candidate to the stable release
  • Reset the serial port's baud to 115,200 prior to starting the serial monitor, allowing the use of --speed and --monitor together

MabezDev
MabezDev approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset the serial port's baud to 115,200 prior to starting the serial monitor, allowing the use of --speed and --monitor together

Ran into this so many times! Thanks for fixing!

@MabezDev MabezDev merged commit cd4ec7c into esp-rs:master Jan 26, 2022
@jessebraham jessebraham deleted the fixes/misc branch January 26, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessebraham @MabezDev