Skip to content

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Feb 10, 2022

(This is for an upcoming PR adding support for flash encryption)

The encrypted flag should be a symbol, not an integer. See:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32c3/security/flash-encryption.html#encrypted-partition-flag

This adds the Flags type (of which there is currently only one, encrypted) and updates the relevant code. Also performed some simplification, cleanup, and formatting while I was in here.

@jessebraham jessebraham requested a review from MabezDev February 10, 2022 17:19
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 8bd0dd4 into esp-rs:master Feb 11, 2022
@jessebraham jessebraham deleted the fixes/partition-table branch February 11, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants