Skip to content

Fix a logical error preventing the board-info subcommand from being invoked #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix a logical error preventing the board-info subcommand from being invoked #138

merged 1 commit into from
Mar 4, 2022

Conversation

jessebraham
Copy link
Member

I messed this up in a previous refactor, my bad. Should work now but please confirm.

@jessebraham jessebraham requested review from bjoernQ and MabezDev March 3, 2022 19:47
MabezDev
MabezDev approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

bjoernQ
bjoernQ approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - works fine for me

@bjoernQ bjoernQ merged commit bfda278 into esp-rs:master Mar 4, 2022
@jessebraham jessebraham deleted the fixes/board-info branch March 4, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessebraham @bjoernQ @MabezDev