Add partition-table subcommand #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenstaro
force-pushed
the
add-partition-subcommand
branch
4 times, most recently
from
ccc107b
to
292238e
Compare
svenstaro
force-pushed
the
add-partition-subcommand
branch
from
292238e
to
e66434e
Compare
icewind1991
reviewed
May 1, 2022
Comment on lines
+68
to
+75
| #[clap(long, required_unless_present_any = ["info", "to-csv"])] | ||
| to_binary: bool, | ||
| /// Convert binary partition table to CSV representation | ||
| #[clap(long, required_unless_present_any = ["info", "to-binary"])] | ||
| to_csv: bool, | ||
| /// Show information on partition table | ||
| #[clap(short, long, required_unless_present_any = ["to-binary", "to-csv"])] | ||
| info: bool, |
There was a problem hiding this comment.
it might make more sense to have these as sub commands
There was a problem hiding this comment.
I think it's fine as they terminate the chain of commands and I don't like too deeply nested subcommands.
jessebraham
requested changes
May 3, 2022
There was a problem hiding this comment.
Thank you so much for this, sorry again for the delays!
Overall I think this looks quite good, I don't have much else to say about the submitted code which isn't nitpicking. There are a couple things I'd like to see added though, if you are willing; I can do it myself if you are not feeling up to it however, please just let me know.
- Could you please update the top-level README to include the new MSRV?
- You have updated
espflash/src/main.rs, but notcargo-espflash/src/main.rs; would it be possible for you to add this functionality tocargo-espflashas well?
|
Cool, all done! |
jessebraham
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165 and fixes #163. It's quite pretty too:
This is quite a bit more than I bargained for but I think this makes sense as parsing of the binary stuff is also in esp-idf's
gen_esp32part.pyand that's Python so we can't have that!I had to bump the MSRV to 1.58 but I hope that's ok.