Use variable timeouts for different flash operations #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some operations (like erasing or writing flash) will depend on the size being erased or written. For larger sizes (e.g 1MB), 3 seconds is often not enough. Timeouts taken from esptool.py.
kelnos
force-pushed
the
variable-timeouts
branch
from
8a79202 to
44be30c
Compare
icewind1991
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some operations (like erasing or writing flash) will depend on the size being erased or written. For larger sizes (e.g 1MB), 3 seconds is often not enough.
Timeouts taken from esptool.py (https://github.com/espressif/esptool/blob/1db7a236c5ad5ed989ba6df0d9e0eabe060a0357/esptool.py#L77-L87).