Write the ESP32 & ESP32-C3 partition table with nvs and phy_init partitions #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelnos
force-pushed
the
better-default-esp32-parttable
branch
from
ea8212d to
28fc3ed
Compare
The partition type can be inferred from the SubType enum, so no need to pass both.
kelnos
force-pushed
the
better-default-esp32-parttable
branch
from
28fc3ed to
bfba9a0
Compare
kelnos
changed the title
icewind1991
approved these changes
Sep 4, 2021
kelnos
commented
Sep 5, 2021
| APP_SIZE, | ||
| ); | ||
| ) | ||
| .to_bytes(); |
There was a problem hiding this comment.
Ugh, that was dumb. Thanks for fixing that up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the ESP-IDF defaults for the offsets and sizes of the nvs and phy_init partitions. The factory partition was originally being written in the ESP-IDF default location, so it didn't need to move.
This also changes the
Partitionconstructor; there's no need to pass the partition type since it can be inferred from the subtype.