-
Notifications
You must be signed in to change notification settings - Fork 148
Add basic serial monitor #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After addressing the issue clippy
spotted, this is all good I think!
This seems to work fine on my Mac, however it will not build on Windows for me. I believe |
1228ae3
to
dc3d776
Compare
switched to crossterm for doing the terminal handling which does work under windows |
I'm unfortunately still having issues on Windows :(
|
Okay, if it's working for you then it's likely that the issue lies with my installation. I recall having changed the default PowerShell encoding at some point so that may have something to do with it. Thank you for checking. |
324ff5f
to
4ddfb4a
Compare
4ddfb4a
to
5e54a91
Compare
@jessebraham can you see if the latest commit changes anything for you? |
That seems to have fixed it, thanks! |
Adds a basic
--monitor
option to open a serial monitor after flashing is completed