Skip to content

HTTP Client library: decouple TLS handling #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 13, 2016
Merged

HTTP Client library: decouple TLS handling #1857

merged 8 commits into from
Apr 13, 2016

Conversation

igrr
Copy link
Member

@igrr igrr commented Apr 4, 2016

With this change, TLS support is linked into the final program only when certain overloads of HTTPClient::begin are used. Using an overload which does not take certificate fingerprint will save approximately 5k of DRAM.

Fixes #1855.

@igrr igrr mentioned this pull request Apr 4, 2016
Closed
@igrr
Copy link
Member Author

igrr commented Apr 4, 2016

Memory usage changes with this pull request:

sketch                           data     rodata   bss      text     irom0.text   dram     flash
Authorization.ino                -1       -5364    -344     -216     -34150       -5709    -39731  
ReuseConnection.ino              -1       -5364    -368     -216     -34150       -5733    -39731  
httpUpdateSPIFFS.ino             -1       -5728    -352     -216     -33526       -6081    -39471  
httpUpdate.ino                   -1       -5728    -352     -216     -33542       -6081    -39487  
BasicHttpClient.ino              -1       -5364    -344     -216     -34150       -5709    -39731  
StreamHttpClient.ino             -1       -5364    -352     -216     -34134       -5717    -39715

sticilface added a commit to sticilface/ESPmanager that referenced this pull request Apr 5, 2016
@sticilface
Revert back to old methods as esp8266/Arduino#1857 provides a fix for…
d84ad7b 
… heap usage.
@sticilface
Copy link
Contributor

Works, and tested. Thanks for the fast turn around. quick fix for 5K:)

@sticilface sticilface mentioned this pull request Apr 6, 2016
Closed
@andig
Copy link
Contributor

andig commented Apr 8, 2016

Tested and working. Think I'm even seeing an 8k improvement though?

@igrr igrr force-pushed the http_client_refactoring branch from c2ba0c9 to a455f22 Compare April 9, 2016 09:48
@igrr igrr merged commit f3b6ec1 into master Apr 13, 2016
@igrr igrr deleted the http_client_refactoring branch April 13, 2016 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igrr @sticilface @andig